[Konsole-devel] Review Request: Open links from konsole with single mouse click

[Asko Eronen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105282/
-----------------------------------------------------------

(Updated July 10, 2012, 6:07 p.m.)


Review request for Konsole.


Changes
-------

Changed usability behavior as suggested by Jekyll. Now the Single Click option depends on Underline Links setting. UI should also be less confusing now.

Changed variable and function naming policy as suggested by Kurt.


Description
-------

Added optional feature in konsole, which allows opening links with single mouse click.

By default, the option is disabled. It can be enabled from profile manager -> Mouse -> "Mouse Click opens links"


Diffs (updated)
-----

  src/EditProfileDialog.h f9e35e6 
  src/EditProfileDialog.cpp 678636e 
  src/EditProfileDialog.ui e4196de 
  src/Profile.h 10a71b6 
  src/Profile.cpp aded720 
  src/TerminalDisplay.h 8d91ddb 
  src/TerminalDisplay.cpp 6a47299 
  src/ViewManager.cpp 0d01aae 

Diff: http://git.reviewboard.kde.org/r/105282/diff/


Testing
-------

Tested with simple terminal usage using gentoo package manager, irssi and htop. No problems ocured with them.


Thanks,

Asko Eronen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120710/a43e38ca/attachment.html>