[Konsole-devel] Review Request: Provide GUI for line spacing

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105478/#review15587
-----------------------------------------------------------



src/EditProfileDialog.ui
<http://git.reviewboard.kde.org/r/105478/#comment12163>

    I think it should be the pixels between two "horizontal" lines.
    
    Actually, I think just "lines" is better. In the context of a terminal emulator, line implies horizontal  and row/column implies vertical.
    
    



src/Profile.cpp
<http://git.reviewboard.kde.org/r/105478/#comment12162>

    I think this new option should belong to the APPEARANCE_GROUP.
    
    Yes, the implementation in this patch put the option under the "Terminal Features" section in the "Advanced" tab (That is OK at the moment, because the "Appearance" tab is already crowded.), but I think it is really an appearance thing, not emulator feature (compare it with the other threee options under the "Terminal Emulator" section). 
    
    


- Jekyll Wu


On July 8, 2012, 2:56 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105478/
> -----------------------------------------------------------
> 
> (Updated July 8, 2012, 2:56 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This provides a profile GUI to change the line spacing  (0-5).  Due to the Qt4.8/BIDI issues, allowing the user to  change the spacing allows the user to fix any issues w/ the font they are using.
> 
> 
> This addresses bug 279490.
>     http://bugs.kde.org/show_bug.cgi?id=279490
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h d7254c3 
>   src/EditProfileDialog.cpp a2fca3a 
>   src/EditProfileDialog.ui 169298b 
>   src/Profile.h 6fafd12 
>   src/Profile.cpp 3fbdc3e 
>   src/TerminalDisplay.h 10aefad 
>   src/ViewManager.cpp 76d710d 
> 
> Diff: http://git.reviewboard.kde.org/r/105478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120709/57775d3e/attachment.html>