[Konsole-devel] Review Request: Add setting for konsole control drag

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105423/#review15428
-----------------------------------------------------------



src/EditProfileDialog.cpp
<http://git.reviewboard.kde.org/r/105423/#comment12056>

    extra trailing space



src/EditProfileDialog.ui
<http://git.reviewboard.kde.org/r/105423/#comment12057>

    This "Control Drag" is not good enough. It causes understanding problem for users and translators. 
    
    The KDE3 phrase is "Require Ctrl key for drag and drop".



src/Profile.h
<http://git.reviewboard.kde.org/r/105423/#comment12059>

    The name is a bit confusing. The thing is not "CtrlDrag" is enabled or not, it is that whether "Ctrl" is required for dragging selected text. So something like "CtrlRequiredForDrag" would be better, IMO.



src/TerminalDisplay.h
<http://git.reviewboard.kde.org/r/105423/#comment12058>

    well, _controlDrag is no better than _ctrlDrag. 
    
    If renaming is really needed, I think _ctrlRequiredForDrag or something like that would be better. 


- Jekyll Wu


On July 5, 2012, 1:28 p.m., Scott Kitterman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105423/
> -----------------------------------------------------------
> 
> (Updated July 5, 2012, 1:28 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
>     Description: Add setting for control drag
>     Both KDE 3 and KDE 4.7 and 4.8 default to requiring click and control to drag
>     test in konsole.  This was not required in KDE 4.0 - 4.6 and some people
>     prefer each method.  At the moment, changing this requires recompiling
>     konsole, which is suboptimal.  This patch adds a selection option in
>     the profile configuration options to change this at run time.
>     Addresses complaints about the fix in https://bugs.kde.org/show_bug.cgi?id=165923.
> 
> 
> This addresses bug 165923.
>     http://bugs.kde.org/show_bug.cgi?id=165923
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 2345925 
>   src/EditProfileDialog.cpp f5cfa8c 
>   src/EditProfileDialog.ui 8b8e83c 
>   src/Profile.h 83616c4 
>   src/Profile.cpp 67cd80e 
>   src/TerminalDisplay.h c6e5972 
>   src/TerminalDisplay.cpp 112925f 
>   src/ViewManager.cpp 92ab0b1 
> 
> Diff: http://git.reviewboard.kde.org/r/105423/diff/
> 
> 
> Testing
> -------
> 
> The most recent KDE I have running is 4.8.4.  I first developed this patch for 4.8.4, compiled it and verified click/drag worked either with or without control based on the setting.  The code required minimal adaptation to bring it up to trunk.
> 
> 
> Screenshots
> -----------
> 
> Designer Screenshot with master
>   http://git.reviewboard.kde.org/r/105423/s/613/
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120705/c887de98/attachment.html>