[Konsole-devel] Review Request: "New Tab" action should always open new tab using the default profile

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103809/
-----------------------------------------------------------

(Updated Jan. 28, 2012, 2:54 p.m.)


Review request for Konsole.


Changes
-------

Fix typo of bug number


Description (updated)
-------

Currently, "New Tab" action will create new tab using the _defaultProfile of MainWindow. In normal usage, that does not cause differece than using _defaultProfile of SessionManager. However, when "--profile" option is used, _defaultProfile of MainWindow refers to the profile specifed on the command line. So in that case, "New Tab" is more like "Clone Tab".

I think "New Tab" should always open new tab using the default profile, no matter what command line options are given. That is the most simple and intuitive behavior. 

Another argument is consistency. Since bug 184788 has been fixed, "New Tab" now behaves like "New Tab" in the case of "-e" option, but more like "Clone Tab" in the case of "--profile" option. I think that is only confusing.

The patch is simple. However, it is the first step towards getting rid of _defaultProfile from MainWindow. So It is better to discuss the idea first here.

My general thought is making "New Tab" action simple and adding "Clone Tab"  action as its complement, as posted in bug 292518 and bug 254976


Diffs
-----

  src/MainWindow.cpp 745b51f 

Diff: http://git.reviewboard.kde.org/r/103809/diff/diff


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120128/779f9e33/attachment.html>