[Konsole-devel] Review Request: Fix Bug # 256353 - "Selecting text by triple click and scrolling up causes only the visible contents to be selected"

[Jekyll Wu]

> On Jan. 21, 2012, 6:55 p.m., Kurt Hindenburg wrote:
> > From my testing, the patch appears to work w/o any regressions.  We can either commit and find any regressions before 4.9 is released or someone further research why the code is as-is.

Then I would say it is better to commit it now since we have enough time before 4.9 and the effective change is only two lines. 


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103724/#review9992
-----------------------------------------------------------


On Jan. 18, 2012, 9:05 a.m., Shlomi Fish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103724/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 9:05 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This is a tentative patch to fix https://bugs.kde.org/show_bug.cgi?id=256353 where selecting the text by triple clicking and scrolling up causes only the visible contents to be selected.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=256353.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=256353
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 3d8944c 
>   src/ScreenWindow.cpp 5249993 
>   src/TerminalDisplay.cpp 516f546 
> 
> Diff: http://git.reviewboard.kde.org/r/103724/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shlomi Fish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120128/2d98bb57/attachment.html>