[Konsole-devel] Review Request: add action to cd into dropped directory

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103775/#review10094
-----------------------------------------------------------

Ship it!


I'm not sure what the best action name is: "Change directory to"

"cd to" seems a bit short

- Kurt Hindenburg


On Jan. 23, 2012, 1:45 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103775/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2012, 1:45 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> That action is shown only when:
> 
> 1). only one item is selected and dropped
> 2). that item is local instead of remote
> 3). that item is a directory instead of a file
> 
> The code is not complex. And I know I need to change some names. The main issue is the UI string for this action. "Go to There" is clearly not good enough :(
> 
> 
> This addresses bug 197867.
>     http://bugs.kde.org/show_bug.cgi?id=197867
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp 38c3cae 
> 
> Diff: http://git.reviewboard.kde.org/r/103775/diff/diff
> 
> 
> Testing
> -------
> 
> works for me in stand-alone konsole and konsolepart hosts(dolphin, kate)
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120126/58e3b6cd/attachment.html>