[Konsole-devel] Review Request: Merge request: merge the code of adding and using global setting

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103714/#review9995
-----------------------------------------------------------

Ship it!


My inclination is to commit this and we can continue to work on it.  Thanks for the work.

- Kurt Hindenburg


On Jan. 17, 2012, 9:41 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103714/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2012, 9:41 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I have migrated some options from profiles into global setting and pushed it as the konsole-settings-v2 branch.
> 
> Migrated options :
> 
>   * "Show menu bar in new windows" ==> "Show menu bar initially in Konsole window"
>   * All tab bar related options are migrated.
> 
> new global options:
> 
>   * add the option of enabling or disabling menu accelerators. Disabling is the default.
> 
> 
> There are some small issues left. For example, both pages in the global setting dialog use the same icon. But  most work which can be done easily at the moment is done and it works. 
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/103714/diff/diff
> 
> 
> Testing
> -------
> 
> Neither regressions nor new problems were found when using stand-alone konsole and konsolepart. 
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120121/5368f39b/attachment.html>