[Konsole-devel] Review Request: The "Close Tab" action in context menu is problematic

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103743/
-----------------------------------------------------------

Review request for Konsole and Eike Hein.


Description
-------

The patch is trivial. It just renames that action into "Close Session". What I want to bring into discussion is something more essential.

The basic problems of "Close Tab" in the context menu :

1). It does not make sense in the context of konsolepart, since konsolepart does not support tabs now (probably never?).

2). Even in the context of stand-alone Konsole, it is inaccurate and misleading. It not only close current tab, bug also close current session. That difference manifest itself more clearly when using split view. When using split view, there are multiple views(thus tabs) for one session in multiple ViewContainers. Users might get the wrong idea that "Close Tab" only close current tab in this container, until they find the session and all related tabs are gone.

However, simply renaming it into "Close Session" is also problematic :

1). From the point of view of users, 'Session' is less straight forward than the concept of 'Tab'. And We currently provide various operations based upon the concept of 'Tab':  'New Tab', 'Rename Tab', 'Detach Tab', "Copy input to", and the '--new-tab' option. So we either change them all or stick to the concept of 'Tab'.

2). Yakuake, the most important user of konsolepart, has its own concept of session and provide its own "Close Session" action. So renaming that action to "Close Session" will cause confusion to yakuake users.

Review #102630 suggests removing that action from the context menu of konsolepart. I don't think that is a good idea.

Basically, I think there is no ideal solution to the essential problem until we change the way split view works. Although the current idea is interesting, I guess that is not what most users expect and want. They mostly want the split feature in screen/tmux, terminator and yakuake. In that mode, the relationship between view and session is one-to-one.


This addresses bug 225854.
    http://bugs.kde.org/show_bug.cgi?id=225854


Diffs
-----

  src/SessionController.cpp 23b307c 

Diff: http://git.reviewboard.kde.org/r/103743/diff/diff


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120120/419ed268/attachment.html>