[Konsole-devel] Review Request: check for wrong profile absolute path

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102749/#review9945
-----------------------------------------------------------


Sorry for late response. I think the updated patch looks good and it works fine for me. 

The only left issue is we still use absolute path for recording shortcuts internally. Maybe we can also change that.

But that is another story. From the point of view of users, konsolerc will use "name.profile" instead of absolute path after applying this patch.

I will vote for applying this patch. Any objection?


- Jekyll Wu


On Oct. 5, 2011, 10:57 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102749/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2011, 10:57 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> A small and not intrusive fix for check absolute profile path, it is resolve the problem of 'Favorites Profiles' and 'Profile Shortcuts' path in konsolerc.
> 
> 
> This addresses bug 283102.
>     http://bugs.kde.org/show_bug.cgi?id=283102
> 
> 
> Diffs
> -----
> 
>   src/SessionManager.cpp 9a465ab 
> 
> Diff: http://git.reviewboard.kde.org/r/102749/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120119/e8b2b003/attachment.html>