[Konsole-devel] [Bug 256353] Selecting text by triple click and scolling up causes only the visible contents to be selected

[Shlomi Fish]

https://bugs.kde.org/show_bug.cgi?id=256353


Shlomi Fish <shlomif at shlomifish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shlomif at shlomifish.org




--- Comment #5 from Shlomi Fish <shlomif shlomifish org>  2012-01-18 08:59:42 ---
Hi Jekyll,

(In reply to comment #4)
> Sorry for no response. 
> 
> Yes, submitting patch to review board is always the preferred way.
> 
> As for the patch itself, I actually made similar analysis after posting comment
> #1, and I thought the first and real problem was why
> ScreenWindow::setSelectionStart() was ever called, which should not happen
> IMHO, to reset the start point of selection during scrolling up.  

I think it is called because the selection start/end are calculated based on
the current scroll position and so it needs to be updated whenver the user
scrolls the viewport (don't know why this design decision was made, but that's
how it is.)

> My little
> hack was setting 'swapping' to false in force in the case of triple clicking
> and scrolling, and it seemed to work. Anyway, it was just hack and I didn't
> make further investigation.
> 
> In general, I feel the real problem is not in those setSelectionStart() methods
> themselves, but in how and when they are called. So changing the internal logic
> of those methods might be dangerous and cause new regressions.

>From my testing (which I admit was not very comprehensive), the scrolling and
selection continued to work properly with this patch.

In any case, I'll submit this patch to the review board.

Regards,

-- Shlomi Fish

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.