[Konsole-devel] Review Request: Change the default shortcut for 'clear scrollback and reset'

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103660/#review9687
-----------------------------------------------------------

Ship it!


Looks good. I think ctrl+shift+k is OK. Thanks.

- Kurt Hindenburg


On Jan. 9, 2012, 6:51 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103660/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 6:51 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I think the bug report is quite sensible. Scrollback is an important asset, but it can't be recovered once gone. So I think it is a good idea to reduce the chance of losing scrollback due to accidental operation.
> 
> The pros and cons of choosing  Ctrl + Shift + K
> 
> pros: it is easy to press , good for the wrist of left hand
>  
> cons: it require two hands. But that should not be a big problem since having both hands on keyboard is the normal case when using konsole.
>   
> Actually, I think Ctrl + Alt + K is even better. But it seems most default shortcuts use the combination of 'Ctrl + Shift'.
> 
> 
> This addresses bug 282593.
>     http://bugs.kde.org/show_bug.cgi?id=282593
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 60d3f36 
> 
> Diff: http://git.reviewboard.kde.org/r/103660/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120110/2ff7fbf8/attachment.html>