[Konsole-devel] Review Request: Add hidden option for controlling the behavior of bell

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104013/#review10729
-----------------------------------------------------------

Ship it!


Very nice.  This is better than what we have currently.  Konsole3 did have a GUI options to change this.  All it would be is a drop down menu item.  If you want to work on another option to change the tab icon to a 'bell' that would be fine also.
Please commit.

- Kurt Hindenburg


On Feb. 18, 2012, 9:54 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104013/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2012, 9:54 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> My main thought has been posted here:
> 
> http://lists.kde.org/?l=konsole-devel&m=132940437430773&w=2
> 
> 
> This addresses bugs 155622 and 177861.
>     http://bugs.kde.org/show_bug.cgi?id=155622
>     http://bugs.kde.org/show_bug.cgi?id=177861
> 
> 
> Diffs
> -----
> 
>   src/Profile.h 8ec86d3 
>   src/Profile.cpp d617e9e 
>   src/ViewManager.cpp f39cda4 
> 
> Diff: http://git.reviewboard.kde.org/r/104013/diff/
> 
> 
> Testing
> -------
> 
> Visual bell and system notifiation works fine as expected. No idea about beep, since beep just doesn't work at all in my system.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120218/b6024cf6/attachment.html>