[Konsole-devel] Review Request: Mention the number of tabs in the "Close Multiple Tabs" dialog

Vishesh Handa handa.vish at gmail.com
Sat Feb 18 20:44:57 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104002/#review10728
-----------------------------------------------------------


Thanks for committing, but next time a simple "Ship it" would have been okay.

( And you could iterate what is wrong, so I could fix it )

- Vishesh Handa


On Feb. 17, 2012, 4:03 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104002/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2012, 4:03 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I think it gives the user a better impressions of what all is open.
> 
> I'm not sure if the number should be bold or not.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 128953f 
> 
> Diff: http://git.reviewboard.kde.org/r/104002/diff/
> 
> 
> Testing
> -------
> 
> Works fine.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120218/dc240f45/attachment.html>


More information about the konsole-devel mailing list