[Konsole-devel] Review Request: Finer grained choices for X Selection/Clipboard

[Adam Batkin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103861/
-----------------------------------------------------------

(Updated Feb. 14, 2012, 3:38 p.m.)


Review request for Konsole.


Changes
-------

Updated patch allows you to [optionally] copy selection to Clipboard automatically, but it always goes to the X Selection


Description
-------

* Creates new "Mouse" Profile Options tab with all of the mouse stuff
* Selected text can now go to X Selection AND/OR Clipboard (instead of OR)
* Middle-Mouse clicks can paste from X Selection or Profile

The whole rationale here is that I almost never care about the X Selection (and
I'm probably not alone). And in the few cases where I DO care, well, that's my
problem. So this patch leaves all of the defaults as-is (no one will notice a
change) but for people for whom it makes a difference, now they can control
what is going on.


This addresses bug 183490.
    http://bugs.kde.org/show_bug.cgi?id=183490


Diffs (updated)
-----

  src/EditProfileDialog.h 6c5f91d 
  src/EditProfileDialog.cpp 38a3c51 
  src/EditProfileDialog.ui a9c600c 
  src/Profile.h 8ec86d3 
  src/Profile.cpp d617e9e 
  src/SessionController.h 7738e45 
  src/SessionController.cpp 7f31d7f 
  src/TerminalDisplay.h 0ea9669 
  src/TerminalDisplay.cpp 2d7b0fe 

Diff: http://git.reviewboard.kde.org/r/103861/diff/


Testing
-------


Screenshots
-----------

konsole "Mouse" profile configuration tab
  http://git.reviewboard.kde.org/r/103861/s/430/


Thanks,

Adam Batkin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120214/c42fd154/attachment.html>