[Konsole-devel] Review Request: allow showing shell title on window caption independently of the format of tab title

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103978/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

The purpose is allow user to choose showing the "window title" set by escape sequence as caption indepdently upon the tab title format.

Main changes introduce

  * add one gloabl option for this feature. Disabled by default, of course
  * call setCaption() instead of setPlainCaption(). Now we have " - Konsole" as the ending part like in other KDE applications. I failed to see why not following the (seemingly) common convention.
  * add new signal rawTitleChanged() into class SessionController. The main reason is currently signal titleChanged() is only emitted when the tab title changes. That does go well with the object of showing and updating "window title" indepdently upon tab title format.

The main possible problem with this patch is the newly added rawTitleChanged() signal. Should we add it or change the current condition for emitting the titleChanged() signal?


This addresses bug 162326.
    http://bugs.kde.org/show_bug.cgi?id=162326


Diffs
-----

  src/MainWindow.h 4d0d3cb 
  src/MainWindow.cpp 2881d2a 
  src/SessionController.h 7738e45 
  src/SessionController.cpp 7f31d7f 
  src/ViewProperties.h 59b06d7 
  src/settings/GeneralSettings.ui 34d936a 
  src/settings/konsole.kcfg bc6fa9f 

Diff: http://git.reviewboard.kde.org/r/103978/diff/


Testing
-------

Use emerge, mc and vim for testing. Seems fine. No problem found when switching tab.


Screenshots
-----------

global option
  http://git.reviewboard.kde.org/r/103978/s/434/
An example of using mc
  http://git.reviewboard.kde.org/r/103978/s/435/


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120214/131289fe/attachment.html>