[Konsole-devel] Review Request: Disable the feature of "shortening common dirnames" for %d by deafult
Kurt Hindenburg
kurt.hindenburg at gmail.com
Tue Feb 14 15:00:52 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103949/#review10631
-----------------------------------------------------------
Since the default is to not use %d, the user would have to select it if they want. I'm more inclined to live the code as-is.
Perhaps give some documentation about changing the defaults in the rc file would be better than nothing.
- Kurt Hindenburg
On Feb. 12, 2012, 8:59 a.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103949/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2012, 8:59 a.m.)
>
>
> Review request for Konsole.
>
>
> Description
> -------
>
> The attached patch is only a hack, not a real solution.
>
> I would like to discuss something:
>
> 1). In principle, shall we provide GUI for each effective option? Is it OK to have some hidden options which are only configurable through manual editing, when such options are rarely used or hard to understand for ordinary users? Of course, we must provide clear document for those hidden options in that case.
>
> 2). For this specific option, it currently always reads konsolerc, which is not quite good for konsolepart.
>
>
> This addresses bug 190281.
> http://bugs.kde.org/show_bug.cgi?id=190281
>
>
> Diffs
> -----
>
> src/ProcessInfo.cpp 92e3eca
>
> Diff: http://git.reviewboard.kde.org/r/103949/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120214/31c2291b/attachment.html>
More information about the konsole-devel
mailing list