[Konsole-devel] Review Request: Finer grained choices for X Selection/Clipboard

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103861/#review10556
-----------------------------------------------------------


I haven't read the code in detail. Just apply the patch, compile and play with it for a while.

I'm still in doubt with this feature, especially after seeing that now we have two choices for auto-copying-selected-text-to and two choice for middle-click-pasting-from. 

For the auto-copying-selected-text-to, here are the possible combinations in my observation:

  * selection (Do we need this when that is already the well-known convention?)
  * selection + clipboard (make sense accroding to the feature report )
  * clipboard (I don't follow it: automatically copy selected text into clipboard without touching selection?)  

So I think one checkbox "automaticaly copy selected text into clipboard" is enough.

For the middle-click-pasting-from, if selection and clipboard and in sync when the above checkbox is enabled, do we need the choice again here?

And it is better to attach a screenshot since the patch introduce non-trivial UI changes.

Just my 2 cents. Kurt has the final say. And we still have enough time to decide to accept or reject it before next major release.






- Jekyll Wu


On Feb. 3, 2012, 8:39 p.m., Adam Batkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103861/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2012, 8:39 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> * Creates new "Mouse" Profile Options tab with all of the mouse stuff
> * Selected text can now go to X Selection AND/OR Clipboard (instead of OR)
> * Middle-Mouse clicks can paste from X Selection or Profile
> 
> The whole rationale here is that I almost never care about the X Selection (and
> I'm probably not alone). And in the few cases where I DO care, well, that's my
> problem. So this patch leaves all of the defaults as-is (no one will notice a
> change) but for people for whom it makes a difference, now they can control
> what is going on.
> 
> 
> This addresses bug 183490.
>     http://bugs.kde.org/show_bug.cgi?id=183490
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 6c5f91d 
>   src/EditProfileDialog.cpp e9086e0 
>   src/EditProfileDialog.ui a9c600c 
>   src/Profile.h d78e723 
>   src/Profile.cpp d617e9e 
>   src/SessionController.h 7738e45 
>   src/SessionController.cpp 23b307c 
>   src/TerminalDisplay.h 475fa53 
>   src/TerminalDisplay.cpp da2fb38 
> 
> Diff: http://git.reviewboard.kde.org/r/103861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adam Batkin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120212/5afca062/attachment.html>