[Konsole-devel] Review Request: Accessibility for Konsole
Kurt Hindenburg
kurt.hindenburg at gmail.com
Sat Feb 11 16:34:44 UTC 2012
> On Jan. 27, 2012, 5:43 p.m., Frederik Gladhorn wrote:
> > One question I have, do TerminalDisplay::screenWindow() and ScreenWindow::screen() always return a valid object or can they be 0?
> > Are there easier ways to get at the information? I don't know the Konsole code, so I'm happy about advise.
I would suggest checking screenWindow. Why use #ifndef QT_NO_ACCESSIBILITY instead of #ifdef QT_ACCESSIBILITY? Is there a reasonable simple way to test this?
- Kurt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103805/#review10157
-----------------------------------------------------------
On Jan. 27, 2012, 4:47 p.m., Frederik Gladhorn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103805/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2012, 4:47 p.m.)
>
>
> Review request for Konsole, Jeremy Paul Whiting, José Millán Soto, and Sebastian Sauer.
>
>
> Description
> -------
>
> Add accessible interface to Konsole's display window.
>
>
> Diffs
> -----
>
> src/Screen.cpp 3d8944c
> src/TerminalDisplay.h 475fa53
> src/TerminalDisplay.cpp 3b96852
> src/TerminalDisplayAccessible.h PRE-CREATION
> src/TerminalDisplayAccessible.cpp PRE-CREATION
> src/main.cpp c06b08f
> src/CMakeLists.txt e792d5e
> src/Screen.h 330f087
>
> Diff: http://git.reviewboard.kde.org/r/103805/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Frederik Gladhorn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120211/31c851f1/attachment.html>
More information about the konsole-devel
mailing list