[Konsole-devel] Review Request: Add new action "Clone Tab" dedicated for cloning tab/session

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103859/#review10491
-----------------------------------------------------------


This review has been submitted with commit 56acddac933b96c10c782a918a419f6aaf4b2702 by Jekyll Wu to branch master.

- Commit Hook


On Feb. 3, 2012, 6:22 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103859/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2012, 6:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Since "New Tab" always uses default profile now, It might be helpful to add this new action dedicated for the previous handy but potentially confusing functionality.
> 
> The code is not complex. My main concern is whether it should be an action only accessible through keyboard shortcut or also accesible through menu. If accessible through menu, then the name "Clone Tab" is a bit problematic, since it is very similar to the name "Close Tab".
> 
> "Duplicate Tab" might be another choice of name, but I don't think it is as clear as "Clone Tab".
> 
> 
> This addresses bugs 254976 and 292518.
>     http://bugs.kde.org/show_bug.cgi?id=254976
>     http://bugs.kde.org/show_bug.cgi?id=292518
> 
> 
> Diffs
> -----
> 
>   desktop/konsoleui.rc ace6bee 
>   src/MainWindow.h b3dd218 
>   src/MainWindow.cpp ab8bba6 
> 
> Diff: http://git.reviewboard.kde.org/r/103859/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120210/3b3338ed/attachment.html>