[Konsole-devel] Review Request: Add new action "Clone Tab" dedicated for cloning tab/session

[Jekyll Wu]

> On Feb. 4, 2012, 3:08 p.m., Kurt Hindenburg wrote:
> > "Clone" to me would be take the tab and making an exact clone of it.  This doesn't seem to do that.  For example, if you change any temp parameters, they are not 'cloned'.   I tested changing via qdbus and then cloning that tab.
> > If we do 'clone' it has to be separated from the 'Close Tab'.
> 
> Jekyll Wu wrote:
>     The code should be able clone those temporary changes made to the profile associate to the current tab/session(examples are those command line options: -e, -p ). As for the temporary changes made through dbus methods, they take effect directly on the session without touch profile. On the other hand, the code should work with the 'konsoleprofile' script since that script influence current tab/session through modifying/changing its associated profile.
>     
>
> 
> Kurt Hindenburg wrote:
>     OK, well if it says 'clone' then people are going to expect an exact clone.  I think it has to be all or nothing.
> 
> Jekyll Wu wrote:
>     I agree with the implication of 'Clone'. 
>     
>     Then what should we do about this feature? 
>     
>     1). write more and complicate code to guarantee 100% clone(I'm not sure whether that is feasible)
>     2). wait for the underlying mechanism to unify so that the current simple code works 100%(That might take time)
>     3). do not use 'Clone', use something less attractive, like '????'(I don't know...), and add documentation about when it does not work 100%.
>
> 
> Kurt Hindenburg wrote:
>     I agree it won't be 100% clone anytime soon.  I would suggest we do what we can, esp. So people seem to want something like clone.  Mimic is the only other I can think of, but I doubt it is much better.  Let's try something for 4.9
>     Thanks

Errr, I do not quite follow the exact meaning of above comment. Shall I commit this simple patch now or not?


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103859/#review10335
-----------------------------------------------------------


On Feb. 3, 2012, 6:22 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103859/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2012, 6:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Since "New Tab" always uses default profile now, It might be helpful to add this new action dedicated for the previous handy but potentially confusing functionality.
> 
> The code is not complex. My main concern is whether it should be an action only accessible through keyboard shortcut or also accesible through menu. If accessible through menu, then the name "Clone Tab" is a bit problematic, since it is very similar to the name "Close Tab".
> 
> "Duplicate Tab" might be another choice of name, but I don't think it is as clear as "Clone Tab".
> 
> 
> This addresses bugs 254976 and 292518.
>     http://bugs.kde.org/show_bug.cgi?id=254976
>     http://bugs.kde.org/show_bug.cgi?id=292518
> 
> 
> Diffs
> -----
> 
>   desktop/konsoleui.rc ace6bee 
>   src/MainWindow.h b3dd218 
>   src/MainWindow.cpp ab8bba6 
> 
> Diff: http://git.reviewboard.kde.org/r/103859/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120210/2c4e4890/attachment.html>