[Konsole-devel] Review Request: Get rid of the _defaultProfile member of MainWindow

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103819/#review10322
-----------------------------------------------------------

Ship it!


AFAIK it is fine - thanks.

- Kurt Hindenburg


On Jan. 29, 2012, 1 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103819/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 1 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> _defaultProfile was previously used to record the profile to be used for the "New Tab" and the "New Window" action. In other words, it is the actual default profile in practice.
> 
> Now that "New Tab" and "New Window" actions always use the default profile, there is not much need to keep that member anymore. It is actually a little confusing to have both the concept of  applicatioin-wide default profile and the concept of window-wide default profile.
> 
> 
> Diffs
> -----
> 
>   src/Application.h 7415fd5 
>   src/Application.cpp 646cd4b 
>   src/MainWindow.h 2fb1803 
>   src/MainWindow.cpp 7908394 
> 
> Diff: http://git.reviewboard.kde.org/r/103819/diff/diff
> 
> 
> Testing
> -------
> 
> I checked the "-e", "--profile", "-p", and "--tabs-from-file" options. No regression observed so far.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120203/0f93ae49/attachment.html>