[Konsole-devel] Review Request: select right profile name in "saveFavorites()".

Commit Hook null at kde.org
Thu Feb 2 15:52:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103807/#review10287
-----------------------------------------------------------


This review has been submitted with commit cebc42d11b912c656d916a68b91b3b1e3094b2b4 by Kurt Hindenburg to branch KDE/4.8.

- Commit Hook


On Jan. 28, 2012, 11:13 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103807/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 11:13 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Do not use "profile->name()" for retrieve profile name, but take it from profile path.
> 
> When a profile name is changed (ex. test -> test2):
> 
> profile->path() (/home/xxxx/.../test.profile)
> profile->name() (test2.profile)
> 
> but the real profile name is test.profile.
> 
> This patch fix this problem.
> 
> 
> This addresses bug 292637.
>     http://bugs.kde.org/show_bug.cgi?id=292637
> 
> 
> Diffs
> -----
> 
>   src/SessionManager.cpp 266201a 
> 
> Diff: http://git.reviewboard.kde.org/r/103807/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120202/b7e0cc5d/attachment.html>


More information about the konsole-devel mailing list