[Konsole-devel] Review Request: Refactor the code of ssh command parsing

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107816/#review23869
-----------------------------------------------------------


 AT first glance, it looks good.

The user is not picked up when using - "ssh earth -l kurthindenburg" - might check other options at the end as well.  These ssh work even though the man seems to say the options should be before the host.

For the 2 new test files - likely should put you as copyright and update year.

- Kurt Hindenburg


On Dec. 20, 2012, 8:29 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107816/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 8:29 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> The initial motivation is to make it easier for konsole to support other ssh-like commands, like mosh (bug 308102).  In short, this refactoring has done three things:
> 
>   1. Move the logic into one separate and static method, which means it can be easily tested and substituted.
>   2. Add some simple testcases to catch potential regressions.
>   3. Refactor the internal logic to make it more readable.
> 
> The code now lives in the adaptee/ssh-parse-refactor  branch .
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/107816/diff/
> 
> 
> Testing
> -------
> 
> No regression catched in daily usage and the testcases.
> 
> Kurt has also done some basic testing using the new code (many thanks). 
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121222/84f1d533/attachment.html>