[Konsole-devel] Review Request: Add warning dialog when pasting large # chars

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107570/#review23820
-----------------------------------------------------------

Ship it!


Looks fine to me.

Just two minor issues:

1. why is the guard increased from 8K to 80K ? I think 8K is already large enough.

2. "ShowPasteDialog" is a little generic. What about "ShowPasteHugeTextWarning" ? I'm suggesting that because  I remember there is another feature request for showing warning when users paste multi-line text (not necessarily huge).






- Jekyll Wu


On Dec. 21, 2012, 2:55 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107570/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 2:55 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> A quick fix to display a warning when pasting large amounts of text - the bug report is about canceling but I don't see how that is possible.
> 
> 8000 limit is random - 80 chars * 1000 lines
> 
> The dialog blocks the gui
> 
> What do people think about this?
> 
> 
> This addresses bug 162625.
>     http://bugs.kde.org/show_bug.cgi?id=162625
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp c4ad23f 
> 
> Diff: http://git.reviewboard.kde.org/r/107570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121222/fd4a3ac8/attachment.html>