[Konsole-devel] Review Request: Prevent the opening of two or more "edit profile dialogs" per session.

[Francesco Cecconi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107640/
-----------------------------------------------------------

(Updated Dec. 9, 2012, 12:23 p.m.)


Review request for Konsole.


Changes
-------

Free the dialog pointer when a session is closed.


Description
-------

Looking at the code, I have two solutions (or simple reflections :) for the issue described in the bug.
Actually one of these solutions, the second, does not resolve completely the issue but only the case reported in the bug report.


First
Making "edit profile dialog" a modal dialog, but this limits the possibility to change
more profiles(one for session) without closing the first one.

Second
Fixing the wrong behaviour to open two or more "edit dialogs" for one session/tab with 
the same profile (it should be fixed anyway and this is the issue of the bug 311270 ), 
but not the crash with two or more "edit dialog", one for different session(tabs)
with the same profile.

Fixed
one tab/session -> only one edit profile dialog at the same time ( 311270 )

Not fixed
tab1 -> edit profile (profile1)
tab2 -> edit profile (profile1) 

However, to fix the second part is really hard at moment with edit profile signal in the session code. 

NOTE:The issue appears only when transparency property is modified by one of the two profiles.


This addresses bug 311270.
    http://bugs.kde.org/show_bug.cgi?id=311270


Diffs (updated)
-----

  src/EditProfileDialog.h c85bd11 
  src/EditProfileDialog.cpp cf95a46 
  src/SessionController.h aefdbc6 
  src/SessionController.cpp fd58ecc 

Diff: http://git.reviewboard.kde.org/r/107640/diff/


Testing
-------


Thanks,

Francesco Cecconi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121209/2d688bc7/attachment.html>