[Konsole-devel] Review Request: Add warning dialog when pasting large # chars

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107570/#review22951
-----------------------------------------------------------



src/TerminalDisplay.cpp
<http://git.reviewboard.kde.org/r/107570/#comment17533>

    Add spaces:
    if (text.length() > 8000) {



src/TerminalDisplay.cpp
<http://git.reviewboard.kde.org/r/107570/#comment17534>

    Could be done as a single liner (split on multiple lines to avoid long line widths):
    if (KMessageBox::warningContinueCancel(…) == KMessageBox::Cancel) 
    and also consider adding a DontAgain so people can turn off this intrusive message


- Kai Uwe Broulik


On Dec. 3, 2012, 10:28 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107570/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2012, 10:28 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> A quick fix to display a warning when pasting large amounts of text - the bug report is about canceling but I don't see how that is possible.
> 
> 8000 limit is random - 80 chars * 1000 lines
> 
> The dialog blocks the gui
> 
> What do people think about this?
> 
> 
> This addresses bug 162625.
>     http://bugs.kde.org/show_bug.cgi?id=162625
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp 871dc9f 
> 
> Diff: http://git.reviewboard.kde.org/r/107570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121204/1c777da0/attachment.html>