[Konsole-devel] Review Request: Don't call updateWebSearchMenu from selectionChanged

[Jekyll Wu]

> On Nov. 30, 2012, 3:07 p.m., Jekyll Wu wrote:
> > Can't recall the exact reason why I wrote it that way. I remember something didn't work without that extra call. But it seems not true now.
> >
> 
> Dawit Alemayehu wrote:
>     Do you want me to push it into the master or 4.9 branch ? If so, how do you deal with porting the fix into master: cherry-pick or merge 4.9 into master ?

Not sure about whether it can catch 4.9.4. Please fix it in master, ten cherry-to KDE/4.9 . 


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107511/#review22823
-----------------------------------------------------------


On Nov. 29, 2012, 12:33 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107511/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 12:33 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Don't call updateWebSearchMenu from selectionChanged since updateWebSearchMenu is called right before the context menu is shown. Filtering URIs becomes a very expensive operation if it is done while the user it selecting text (read: many times in a row) and causes issues like those mentioned in the aforementioned bug report.
> 
> 
> This addresses bug 307973.
>     http://bugs.kde.org/show_bug.cgi?id=307973
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 036bd37 
> 
> Diff: http://git.reviewboard.kde.org/r/107511/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121201/41925811/attachment.html>