[Konsole-devel] Review Request: Add process info gathering support on OpenBSD

[Vadim Zhukov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106129/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 7:29 p.m.)


Review request for Konsole and Jekyll Wu.


Changes
-------

Add missing kInfoProc==NULL check after malloc().
In case anyone asking, previous (pre-patch) code dealt wrong with mibLength as it's in bytes, not in items. And I see no reason to throw out-of-memory exception via operator new - getting process info is not that critical.


Description
-------

ATM Konsole does not support gathering process information on OpenBSD. I've a patch adding such support.
The main idea is to extend already existing FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here and there. If that's not desirable, I could create separate OpenBSDProcessInfo class.

I've also fixed a few nits regarding calling C routines (prepended "::" to sysctl() and such; added kWarning() printouts if they fail). If needed I can do them as a separate diff.


Diffs (updated)
-----

  src/ProcessInfo.cpp 32c86b1 

Diff: http://git.reviewboard.kde.org/r/106129/diff/


Testing
-------

On OpenBSD-CURRENT.


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120823/27a42e20/attachment.html>