[Konsole-devel] Review Request: remove duplicated entry “Show Menu Bar” from KShortcutsDialog.

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106055/#review17614
-----------------------------------------------------------


Well, I find it not easy for me to give a clear idea on this problem. 

Code wise, I prefer the patch in review 104193 because it looks straight forward and easier to follow.  I have to say it takes some time for me to understand this patch. 

On the other hand, from average users' perspective, this solution might be better because there is no UI change. They still always have the "Show MenuBar" action at the familiar position of the context menu.


- Jekyll Wu


On Aug. 16, 2012, 3:05 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106055/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 3:05 p.m.)
> 
> 
> Review request for Konsole, Jekyll Wu and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> remove duplicated entry “Show Menu Bar” when showing the shortcut dialog.
> 
> ref. Jekyll Wu review request: #104193
> 
> 
> This addresses bug 214493.
>     http://bugs.kde.org/show_bug.cgi?id=214493
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 6d35fcd 
> 
> Diff: http://git.reviewboard.kde.org/r/106055/diff/
> 
> 
> Testing
> -------
> 
> seems fine on stand-alone konsole.
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120817/8a26017f/attachment.html>