[Konsole-devel] Review Request: replace the font size slider with a numinput

[Kurt Hindenburg]

> On Aug. 1, 2012, 1:12 p.m., Christoph Feck wrote:
> > > as Konsole has to have integer sizes
> > 
> > Sorry, this is nonsense.
> > 
> > You are confusing pixel metrics, and font point sizes.
> > 
> > Much work has been put into KDE and Konsole to make it respect fractional point sizes, while still forcing integer metrics, and this commit basically destroys this work.
> > 
> > Please update the patch to allow (at least) one decimal for the point size.

I'm still looking at this.  I don't see any other terminal app allowing .x point sizes and I don't see the use case.   I don't really have an issue with putting the .x back in.

I guess I don't quite understand this "respect fractional point sizes, while still forcing integer metrics,"


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105796/#review16765
-----------------------------------------------------------


On July 30, 2012, 2:50 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105796/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:50 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I'm not sure why a slider was used for the font size. And why fractions were allowed as Konsole has to have integer sizes.
> 
> If we really want a slider, kintnuminput has the option to add it as well.
> 
> I also removed the "size :" from the preview label as I was looking at bko 174998.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.ui be3e672 
>   src/EditProfileDialog.h 4715ec5 
>   src/EditProfileDialog.cpp 68d5729 
> 
> Diff: http://git.reviewboard.kde.org/r/105796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120804/a722791b/attachment.html>