[Konsole-devel] Review Request: Change the "Bold" key of ColorScheme from boolean to tri-state

[Kurt Hindenburg]

> On April 17, 2012, 12:45 p.m., Kurt Hindenburg wrote:
> > GO ahead - I would agree that the color boldness should be to only one - I think the profile one was an easy to find option for users.
> 
> Jekyll Wu wrote:
>     Well, if you also think this per-color-bold(heritage from the KDE3 era?) is not that useful or does not make sense anymore, then I think the better choice is to remove this hidden feature.
>     
>     And if applying this patch, there is another thing to consider:  
>     
>      * "Bold=false" does not work before, while it works now(forcing using normal font weight). 
>      * "Bold=false" entries are alreayd used in some colorschemes,  like Linux, GreenOnBlack, etc
>      * That means uses who use the Linux colorsheme would find that they can't have bold text anymore(because Bold=false works now).
>      * To avoid that problem, we need to not only remove existing "Bold=false" entries from konsole repository, but also write some kconf-update script to remove existing "Bold=false" entries from users' konsole data folder.
>     
>     I'm opt to remove that per-color-bold control, because the per-profile "BoldIntense" option should be enough.
>     
>

I'm beginning to think you're correct.  Having the hand-edited colorscheme Bold= never really seemed like a good idea.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104605/#review12569
-----------------------------------------------------------


On April 15, 2012, 11:35 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104605/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 11:35 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Tha patch is trivial. Konsole now supports "Bold=true", "Bold=false" and other values(which all mean using Character::UseCurrentFormat).
> 
> However, I just wonder how useful this per-color boldness controlling could be. We already have the "BoldIntense" per-profile option to enable or disable boldness. Do we need two levels of boldness control: per-profile and per-color in each colorscheme?
> 
> 
> This addresses bug 168300.
>     http://bugs.kde.org/show_bug.cgi?id=168300
> 
> 
> Diffs
> -----
> 
>   src/ColorScheme.cpp 1acb4d4 
> 
> Diff: http://git.reviewboard.kde.org/r/104605/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120419/d8cc3760/attachment.html>