[Konsole-devel] Review Request: Konsole should create new process when some Qt/KDE commandline options are specified

Jekyll Wu adaptee at gmail.com
Wed Apr 18 09:32:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104653/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

The model of "Unique konsole process" is not compatible with some Qt/KDE options. 

One example is the "--display" option, because all Konsole windows belong to the same process clearly can only be shown on the same display. Bug 297224 and bug 297801 are good use cases.

Another example is the "--session" option, which is used for session restore. Its problem is a little tricky. Suppose I have 4 konsole windows (belong to 4 differenct konsole process) on 4 different virtual desktop. When I logout, those 4 konsole process are saved respectively in 4 different files under ~/.kde4/share/config/session/. When I login later, however, due to this "Unique konsole process" model, there will be 4 konsole windows running in the same konsole process, and they fail to show on the 4 different virtual desktop respectively as before. Bug 179010 is one example of this tricky problme(If I understand that report correctly).

This patch is a simple attempt to workaround some common problems/options. The selected Qt/KDE options are based upon my understanding of what they are meant to do. I'm sure the list is imcomplete, but should be fine for this first attempt.


This addresses bugs 179010, 297224 and 297801.
    http://bugs.kde.org/show_bug.cgi?id=179010
    http://bugs.kde.org/show_bug.cgi?id=297224
    http://bugs.kde.org/show_bug.cgi?id=297801


Diffs
-----

  src/main.cpp 898a057 

Diff: http://git.reviewboard.kde.org/r/104653/diff/


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120418/d07340e6/attachment.html>


More information about the konsole-devel mailing list