[Konsole-devel] Review Request: Add formatter %h for local title, which expands to local hostname

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104490/#review12262
-----------------------------------------------------------


Any idea?

- Jekyll Wu


On April 5, 2012, 10:05 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104490/
> -----------------------------------------------------------
> 
> (Updated April 5, 2012, 10:05 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> There are already %h and %H which only apply for ssh connection. For local session, %h current simply does nothing. 
> 
> This simple patch adds the %h for local session. 
> 
> Choosing %h might be a little problematic here. Now %h expands to local hostname in local session, while %h expands to remote host name in remote session. I'm not sure whether that improves consistency or introduces confusion.
> 
> 
> Diffs
> -----
> 
>   src/ProcessInfo.h c78b1e0 
>   src/ProcessInfo.cpp 76792bb 
>   src/TabTitleFormatButton.cpp 6af84b5 
> 
> Diff: http://git.reviewboard.kde.org/r/104490/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120409/680aee8b/attachment.html>