[Konsole-devel] Review Request: Move the line index and isWrapped from a tmp file to memory

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104512/#review12261
-----------------------------------------------------------


Well, the implementaion of scollback history is still like black magic to me, so do not take my comments too serious :)

For the first issue of moving line index and isWrapped into memory, is there some real and nice benefit ?  I mean moving them into memory does reduce the number of files on the disk, but the introduced inconsistency(some one disk, some in memory ) feels uneasy, especially when something goes wrong and we need to debug the code and data.

For the second issue of stop using map(), I think it is actually used now . For example, run "for i in $(seq 100); do dmesg; done" to generate enough scrollback, then press "Shift+Home" to jump to the very beginning, that map() will be called.


- Jekyll Wu


On April 8, 2012, 5:01 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104512/
> -----------------------------------------------------------
> 
> (Updated April 8, 2012, 5:01 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Currently 'unlimited scrollback' uses 3 files: data, line index, isWrapped.  This patch removes the last two and keeps them in memory.  Also the map() is no longer used - I don't think it was actually ever called in practice.
> 
> Currently I have a #define for the new code.  The default is still the old code.
> 
> Perhaps I should use HistoryScrollFile2 instead of the #defines
> 
> 
> Diffs
> -----
> 
>   src/History.h 1a00a56 
>   src/History.cpp 6aefd51 
> 
> Diff: http://git.reviewboard.kde.org/r/104512/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120409/8e9700a7/attachment.html>