[Konsole-devel] Review Request: Use web shortcuts to search selected text on the web

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104493/#review12215
-----------------------------------------------------------


just glancing at this it is OK.  I admit it would be nice.  It is a pity there's so much code but if that what it takes than fine.

- Kurt Hindenburg


On April 5, 2012, 7:02 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104493/
> -----------------------------------------------------------
> 
> (Updated April 5, 2012, 7:02 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Web shortcuts refers to the service defined in "kcmshell4 ebrowsing". That is at least used in Konqueror, Okular and Konversation.
> 
> The use case for Konsole is users (At least I...) often need to search the Internet for something they encounter when using the terminal. A unknown word, a mysterious warning message , a compilation failure message, etc. 
> 
> The code is basically stolen from Okular and Konversation. 
> 
> After applying this patch ,there will be a compilation warning related with "ProviderInfoList". I don't know why it appears but I find that as long as <KUriFilterData> is included, the warning is always there. I guess that warning message is not our's problem.
> 
> PS: there is the prior art.
> http://blog.ubuntu-tweak.com/2010/11/16/gnome-terminal-with-google-search-support.html
> 
> 
> Diffs
> -----
> 
>   desktop/partui.rc bc5c15a 
>   desktop/sessionui.rc 2a05e4e 
>   src/SessionController.h d2d0765 
>   src/SessionController.cpp 75b00fb 
> 
> Diff: http://git.reviewboard.kde.org/r/104493/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> search through web shortcuts
>   http://git.reviewboard.kde.org/r/104493/s/506/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120407/8dd13ad5/attachment.html>