[Konsole-devel] Review Request: The type of TripleClickMode should be enum, instead of boolean.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102742/#review6975
-----------------------------------------------------------


This review has been submitted with commit 59963d8b7e9f0d81e498481cbf07806add02389f by Jekyll Wu to branch master.

- Commit Hook


On Sept. 30, 2011, 10:15 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102742/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 10:15 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> 'Select the whole line' and 'Select from mouse position to the end of line' are not a boolean pair. A checkbox is not a very good choice for easy understanding. I think that property should be of enum type and a combobox with drop-down list is a better choice.
> 
> By the way, I am considering implementing the behavior of "Select from mouse position to the end of line without the final LINEBREAK". Do you think that is a good idea? If so, should that become the third choice, or replace the exising 'Select from mouse position to the end of line'.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 3d73325 
>   src/EditProfileDialog.cpp d736a8a 
>   src/EditProfileDialog.ui fa1a70f 
>   src/Profile.h ed43ba1 
>   src/Profile.cpp eafb4dd 
>   src/ViewManager.cpp a716c4e 
> 
> Diff: http://git.reviewboard.kde.org/r/102742/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> triple click behavior
>   http://git.reviewboard.kde.org/r/102742/s/279/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110930/0819035f/attachment.html>