[Konsole-devel] Review Request: Simplify the ManageProfileDialog: remove the 'OK', 'Apply' and 'Cancel' button, and add 'Close' button instead

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102707/#review6931
-----------------------------------------------------------


This review has been submitted with commit d394f5e2e5df8475b57f5c6623162f04185d7719 by Jekyll Wu to branch master.

- Commit Hook


On Sept. 26, 2011, 8:39 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102707/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2011, 8:39 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The current behaviro is any change(name,show-in-menu, shortcut) is applied immediately and can't be canceled. So 'Ok' and 'Apply' are duplicated and 'Cancel' doesn't do what its name implies(potentially confusing).
> 
> So I think currently a single 'Close' button is enough. Those removed button can be re-added when they are really meaningful.
> 
> 
> Diffs
> -----
> 
>   src/ManageProfilesDialog.cpp 8167507 
> 
> Diff: http://git.reviewboard.kde.org/r/102707/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> only close button
>   http://git.reviewboard.kde.org/r/102707/s/275/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110929/f8a0516e/attachment.html>