[Konsole-devel] Review Request: Allow user to control where the new tab will be placed: after current tab, or at the end?

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102685/
-----------------------------------------------------------

(Updated Sept. 25, 2011, 1:50 a.m.)


Review request for Konsole.


Changes
-------

use combobox and enum instead.


Summary
-------

This is a follow up of my suggestion of putting new tab right after current tab(current behavior on master branch).

The involved logic is not complex. My main concern is the UI part. Is checkbox the right choice? I mean,  technically, "putNewTabAtEnd" and "putNewTabRightAfterCurrentTab" are not a boolean pair. So is combobox a better choice? Also I think the text can be improved. Suggestions are really needed.


This addresses bug 276872.
    http://bugs.kde.org/show_bug.cgi?id=276872


Diffs (updated)
-----

  src/EditProfileDialog.h 46f5a60 
  src/EditProfileDialog.cpp 582bccc 
  src/EditProfileDialog.ui 4d7d175 
  src/Profile.h 7fd1f6c 
  src/Profile.cpp 6254d35 
  src/ViewManager.cpp 727b591 

Diff: http://git.reviewboard.kde.org/r/102685/diff


Testing
-------

No problem found yet.


Screenshots
-----------

new option in EditProfileDialog
  http://git.reviewboard.kde.org/r/102685/s/269/


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110925/6cdacf23/attachment.html>