[Konsole-devel] Review Request: Restore the 'change profile' action under 'Settings' menu

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102686/#review6789
-----------------------------------------------------------


This review has been submitted with commit 989033462f9f018dba1b17929e375bbc26808c58 by Jekyll Wu to branch master.

- Commit


On Sept. 23, 2011, 8:37 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102686/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 8:37 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The patch simply re-add that action. But I think there are 2 issues to consider: 
>  
> 1). Is it really OK to put under 'Settings'?  It is a temporary operation which is applied only to current session. However, putting it under 'Edit' or 'View' do not sounds any better. 
>  
> 2). Should it really be named as 'Change profile'? That 'Change' might be misunderstood as 'Modify'. I think 'Switch Profile' or something similar is clearer.
> 
> 
> This addresses bug 245795.
>     http://bugs.kde.org/show_bug.cgi?id=245795
> 
> 
> Diffs
> -----
> 
>   desktop/sessionui.rc 8d07d99 
> 
> Diff: http://git.reviewboard.kde.org/r/102686/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110924/347fc02b/attachment.html>