[Konsole-devel] Review Request: Do not display "Default Profile" and the first "default" user profile in "New Tab" profiles list

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102670/#review6786
-----------------------------------------------------------


Thanks, I think it is good.  I'm not sure if users will be confused or not; however since they are picking what profiles are shown in the list I think it is OK.

FYI, please don't use tabs in your patches.  It is not a big deal for me to convert to spaces.

- Kurt


On Sept. 24, 2011, 5:14 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102670/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2011, 5:14 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Do not display "Default Profile" and the first user profile if it is checked as the "default"
> 
> 
> This addresses bug 245478.
>     http://bugs.kde.org/show_bug.cgi?id=245478
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp d31e7d0 
> 
> Diff: http://git.reviewboard.kde.org/r/102670/diff
> 
> 
> Testing
> -------
> 
> resolve issue reported by Kurt on https://bugs.kde.org/show_bug.cgi?id=245478 - #11
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110924/f59810c7/attachment.html>