[Konsole-devel] Review Request: Simplify the HistorySizeDialog

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102688/#review6778
-----------------------------------------------------------


The 'save to current profile' was put in there as there were complaints from users.  This was back when the History was in the main menu, not just context menu.

I basically agree w/ your argument but still think there will be confusion.  Putting some text say this change is temporary is likely a bit much.

Should the 'Default' put the settings back to the profile settings?

- Kurt


On Sept. 24, 2011, 9:45 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102688/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2011, 9:45 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The main changes :
> 
>   - the change is not saved into profile and only influences current tab
>   - remove the 'save into profile' checkbox
>   - remove the 'Default' button
>     
> My main argument is current design is (potentially) confusing and not consistent with other actions in the context menu. Most actions(Encoding, Clear Scrollback, Change profile) in the context menu are per tab, which means they only influce current tab and does not update the profile file.  That is why the menu is called as context menu.
> 
> In general, I think the 'Edit Profile' dialog should be the only place where modification can be saved persistently. That would simplify both the concept and implementation.
> 
> 
> This addresses bug 227114.
>     http://bugs.kde.org/show_bug.cgi?id=227114
> 
> 
> Diffs
> -----
> 
>   src/HistorySizeDialog.h e4ee4b2 
>   src/HistorySizeDialog.cpp 79ccaa9 
>   src/SessionController.h 796b579 
>   src/SessionController.cpp d109bb2 
> 
> Diff: http://git.reviewboard.kde.org/r/102688/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> HistorySizeDialog
>   http://git.reviewboard.kde.org/r/102688/s/270/
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110924/d2f94f36/attachment.html>