[Konsole-devel] Review Request: The initinal visibility of menu bar should be determined by profile option

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102502/#review6773
-----------------------------------------------------------

Ship it!


This is great, thanks.  Note that I just commited a change that makes your patch not apply cleanly.

- Kurt


On Sept. 1, 2011, 2:05 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102502/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 2:05 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Currently, the initial visibility of menu bar is actually determined by what is saved into konsolerc during last exit.
> 
> So the profile option "show menu bar in new windows' does not works as expected and makes users confused.
> 
> This patch guarantees the initial visibility of menu bar is determined by profile, not by what is stored in konsolerc .
> 
> 
> This addresses bug 186561.
>     http://bugs.kde.org/show_bug.cgi?id=186561
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 1664350 
>   src/MainWindow.cpp 507fbe3 
> 
> Diff: http://git.reviewboard.kde.org/r/102502/diff
> 
> 
> Testing
> -------
> 
> tested with various combination of profile option and previous status of menu bar under Linux. No test for Mac OS because such a environment is unavailable for me now.
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110924/081055bc/attachment.html>