[Konsole-devel] Review Request: Restore the 'change profile' action under 'Settings' menu

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102686/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

The patch simply re-add that action. But I think there are 2 issues to consider: 
 
1). Is it really OK to put under 'Settings'?  It is a temporary operation which is applied only to current session. However, putting it under 'Edit' or 'View' do not sounds any better. 
 
2). Should it really be named as 'Change profile'? That 'Change' might be misunderstood as 'Modify'. I think 'Switch Profile' or something similar is clearer.


This addresses bug 245795.
    http://bugs.kde.org/show_bug.cgi?id=245795


Diffs
-----

  desktop/sessionui.rc 8d07d99 

Diff: http://git.reviewboard.kde.org/r/102686/diff


Testing
-------


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110923/4a21a368/attachment.html>