[Konsole-devel] Review Request: Copy Bottom line of screen if it isn't a newline

[Francesco Cecconi]

> On Sept. 21, 2011, 6:59 p.m., Jekyll Wu wrote:
> > The comment from Gu sounds reasonable.
> > 
> > Well, I have commited the patch in review 102177 to fix bug #192221. This review can be closed as 'discard' now. Still, thanks for you help, Francesco.
> > 
> >

ok, Jekyll. :)


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102567/#review6717
-----------------------------------------------------------


On Sept. 10, 2011, 4:59 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102567/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2011, 4:59 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> If bottom line of screen has a trailing newline after resizing, screenLines[lines-1] is empty and then, it isn't necessary to copy it
> on newScreenLines. Otherwise you have to copy it.
> 
> Close the bug 192221
> 
> 
> This addresses bug 192221.
>     http://bugs.kde.org/show_bug.cgi?id=192221
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 502360b 
> 
> Diff: http://git.reviewboard.kde.org/r/102567/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110921/30ad34fb/attachment.html>