[Konsole-devel] Review Request: When invoked from terminal, run in foreground just like other emulators

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102454/#review6630
-----------------------------------------------------------


So only when Konsole is started from a terminal, default to using --nofork?  Do we have to add a --fork then?  Can you think of any way someone would use konsole w/o --nofork that would break w/ this patch?

- Kurt


On Aug. 27, 2011, 12:35 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102454/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 12:35 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The current behavior of konsole is quite unique among terminal emulators. Even KDE3 konsole does not behave in this was.
> 
> This has caused some confusion and a couple of bug report. It is better to switch to the traditional way, which impose least surprise to users.
> 
> Since this change may influence many users and many scripts, better put it here for reviewing than just committing it. 
> 
> The first attached patch is more like a proof of concept, rather than a nice solution. But it works as expected.
> 
> 
> This addresses bug 262169.
>     http://bugs.kde.org/show_bug.cgi?id=262169
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 8da7fa1 
> 
> Diff: http://git.reviewboard.kde.org/r/102454/diff
> 
> 
> Testing
> -------
> 
> it works fine with the problems described in bug #262169, bug #173697, bug #217357, and bug #165355.
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110918/a8444662/attachment.html>