[Konsole-devel] Review Request: Add 'Select All' action to select all output in the session

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102372/#review6629
-----------------------------------------------------------


Nice patch - appears to work OK.  Most other apps appear to use Ctrl+A for 'select all' ; Konsole uses that for monitor activity, so I guess  'S' is OK.   The 'A' is underlined in the menu.  Also, you misspelled the menu item ( 2 c).

- Kurt


On Sept. 17, 2011, 6:13 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102372/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2011, 6:13 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> I think this feature is quite handy in a few situations. For example, execute a couple of commands in a new tab then paste the whole output as example in a tutorial or forum post. It is not difficult to implement and gnome-terminal & xfce4-terminal both provide it, so why not?
> 
> The action use Ctrl+Shift+S as default shortcut. My first thought is using Ctrl+Shift+A, but that is already used by 'Moninor activity' action.  Actually, neither of them are very convenient to press. Any idea for better default shortcut?
> 
> 
> This addresses bug 199990.
>     http://bugs.kde.org/show_bug.cgi?id=199990
> 
> 
> Diffs
> -----
> 
>   desktop/sessionui.rc e9894da 
>   src/ScreenWindow.h 51adb42 
>   src/ScreenWindow.cpp 553b4e2 
>   src/SessionController.h 0de39d4 
>   src/SessionController.cpp b357172 
> 
> Diff: http://git.reviewboard.kde.org/r/102372/diff
> 
> 
> Testing
> -------
> 
> It works quite well when the first screen is in use(shell, of course).
> 
> However, when the second screen is in use(less,vim,nano,mc,etc), it does not work very well. I can still use it to select all text in the screen, but copying them will return garbage result. 
> 
> Maybe this action should be disabled when the second screen is used. That requires extra code in Emulation.cpp to emit some signal when the screen is switched.
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110918/9e325101/attachment.html>