[Konsole-devel] Review Request: remove "Close Tab" from KonsolPart context menu

[Gu Rui]

> On Sept. 17, 2011, 5:26 p.m., Francesco Cecconi wrote:
> > Hi Gu, I have investigated for this action in kdevelop, okteta, kate and dolphin with the result:
> > 
> > 1) in kdevelop, "Close Tab" only reload the session and it has a "show/unshow action".
> > 2) kate has a "show/unshow action"
> > 3) dolphin and okteta have "X" for close the widget. (in okteta only reload the session)
> > 
> > now, simply may be not necessary,
> > Francesco
> >

Hi Francesco Cecconi,

I'm using konsole-git on KDE4.7. So I don't see the close "X" on dolphin. But as you have seen it in a newer(maybe) version of KDE(4.8?) I think it would be OK to remove the "Close Tab" from the context menu.

Thanks

Grissiom


- Gu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102630/#review6594
-----------------------------------------------------------


On Sept. 16, 2011, 9:44 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102630/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 9:44 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> remove "Close Tab" from KonsolPart context menu.
> 
> 
> This addresses bug 225854.
>     http://bugs.kde.org/show_bug.cgi?id=225854
> 
> 
> Diffs
> -----
> 
>   desktop/partui.rc d81165a 
> 
> Diff: http://git.reviewboard.kde.org/r/102630/diff
> 
> 
> Testing
> -------
> 
> tested with kdevelop konsole.
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110918/bf9f372a/attachment.html>