[Konsole-devel] Review Request: Do not insert one extra empty line every 500 lines in the saved history

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102652/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

The current behavior is a bit weird. It seems an intentional result(adding separator to make the saved history more readbale?), instead of a bug. However, I really failed to conclude the intention from the deleted code and comment. 

Those deleted code and comment were added in commit d3d909f1c82f5efc252c462b379aad518ffb9bb9 (quite a long time ago. Maybe the context for that extra empty line is already gone.


This addresses bug 225501.
    http://bugs.kde.org/show_bug.cgi?id=225501


Diffs
-----

  src/SessionController.cpp b357172 

Diff: http://git.reviewboard.kde.org/r/102652/diff


Testing
-------

No difference in the saved history( plain text or html) is observed so far.


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110918/cdf1529b/attachment.html>