[Konsole-devel] Review Request: remove "Close Tab" from KonsolPart context menu

[Gu Rui]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102630/#review6556
-----------------------------------------------------------


Frankly speaking, I think remove it is not very well. User should have an other way to close the KPart other than Ctrl+D. So I think the right thing to do is rename it to something sensible, like "Close Konsole" or "Close terminal".

- Gu


On Sept. 16, 2011, 9:44 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102630/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 9:44 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> remove "Close Tab" from KonsolPart context menu.
> 
> 
> This addresses bug 225854.
>     http://bugs.kde.org/show_bug.cgi?id=225854
> 
> 
> Diffs
> -----
> 
>   desktop/partui.rc d81165a 
> 
> Diff: http://git.reviewboard.kde.org/r/102630/diff
> 
> 
> Testing
> -------
> 
> tested with kdevelop konsole.
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110916/b89ceb0b/attachment.html>