[Konsole-devel] Review Request: konsole should never save a profile whose name is empty into disk

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102559/
-----------------------------------------------------------

(Updated Sept. 14, 2011, 2:31 p.m.)


Review request for Konsole.


Changes
-------

screenshots for the warning message in the EditProfileDialog


Summary
-------

Currently it is possible to save profile whose name is empty into disk. Such profile will be saved as .profile and displayed in the ManageProfilesDialog with no name. This is confusing to the users. I think such profile should never saved into disk.

The patch contain 2 changes:
1). In the EditProfileDialog, when user ask to save the profile, pop up a warningbox if its name is empty.
2). In SessionManager, when asked to apply changes to a profile, never save it into disk if its name is empty.


This addresses bug 281268.
    http://bugs.kde.org/show_bug.cgi?id=281268


Diffs
-----

  src/EditProfileDialog.cpp d1edc00 
  src/EditProfileDialog.ui 8883298 
  src/SessionManager.cpp d782b71 

Diff: http://git.reviewboard.kde.org/r/102559/diff


Testing
-------

works well for me so far.


Screenshots (updated)
-----------

warnin message at the bottom
  http://git.reviewboard.kde.org/r/102559/s/258/
warning message right below profile name line
  http://git.reviewboard.kde.org/r/102559/s/259/


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110914/6a334c40/attachment.html>